Skip to content

Conversation

@x4v1l0k
Copy link

@x4v1l0k x4v1l0k commented Aug 25, 2024

Added certificates parsing.
Python Flask web viewer.
Update requirements.txt.
Update files from main branch to dev branch.

@r4ulcl
Copy link
Owner

r4ulcl commented Aug 25, 2024

Hi, I really like the idea and how it's implemented so far. However, could you move all the Flask related code into a separate file within the utils folder to keep everything cleaner?

Additionally, it would be great if the server execution could be controlled with a boolean flag, allowing the IP and port to be passed as parameters, defaulting to 127.0.0.1 instead of 0.0.0.0.

Also, please review the Codacy messages in the pull request to check for any vulnerabilities or errors.

if cert_info not in certs_info:
certs_info.append(cert_info)
if verbose:
print("Certificate information:", cert_info)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (certificate)](1) as clear text. This expression logs [sensitive data (certificate)](2) as clear text.
errors += 1
print("Error in parse_certificates (CAP), probably PCAP cut in the "
"middle of a packet: ", error)
print(".cap Certificates done, errors", errors)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (certificate)](1) as clear text.
except Exception as error:
errors += 1
print("Error in parse_certificates (CAP): ", error)
print(".cap Certificates done, errors", errors)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (certificate)](1) as clear text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants